Fix potential controller sensitive data exposure by sprig template functions #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Kraev <[email protected]>
RaveNoX
force-pushed
the
sprig-controller-exposure
branch
from
92cecc9 to
6521a86
Compare
alvneiayu
approved these changes
Mar 27, 2025
|
thanks a lot for your work @RaveNoX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixing potential controller environment exposure by removing some sprig template functions:
env,expandenv- controller environment variables exposure (which can contain sensitive data)getHostByName- add possibility to resolve dns entries from templates, which is not secure in some casesThis potential exposure is added by PR #1542 where security risks was described in "possible drawbacks" section.
Also, sprig func map is now initialized due module initialization and reusing for rendering, which may improve performance.
In fact is just port of the argocd solution, which described in initial PR #1542
Benefits
Possible drawbacks
No one
Applicable issues
Additional information