Skip to content

Re-factor Notifications and various Utils to DI #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 19, 2024
Merged

Re-factor Notifications and various Utils to DI #924

merged 4 commits into from
Jul 19, 2024

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Jul 19, 2024 •
edited
Loading

  • Re-factor notification management so that notification channels are created when necessary and not at startup
  • Move sync conditions check from static BaseSyncWorker methods to a separate SyncConditions class
  • Use DI for everything
  • Move instrumented tests to default location instead of using them only for the ose build variant

@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jul 19, 2024
@rfc2822 rfc2822 changed the title Re-factor Notifications and various Utils to Hilt Re-factor Notifications and various Utils to DI Jul 19, 2024
@rfc2822 rfc2822 self-assigned this Jul 19, 2024
@rfc2822 rfc2822 force-pushed the notification-hilt branch 2 times, most recently from 100ca10 to 2fc37d4 Compare July 19, 2024 15:03
@rfc2822 rfc2822 marked this pull request as ready for review July 19, 2024 15:07
@rfc2822 rfc2822 merged commit 26f95db into main-ose Jul 19, 2024
8 checks passed
@rfc2822 rfc2822 deleted the notification-hilt branch July 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rfc2822 rfc2822

Labels
refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rfc2822