Skip to content

WebDAV cache: re-factor using Guava and Hilt #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Jul 18, 2024

Currently we have some custom cache implementations that can be replaced by Guava functionality (now as we have the Guava dependency).

  • Use component-wide Guava cache for HeadResponseCache
    • Allows to remove ExtendedLruCache
  • Use per-resource Guava cache as a loading page cache
    • Allows to replace PageLoader by guava.CacheLoader<*>
    • Page size limit increased to 10, but with SoftReference values, so they will be GC-ed if necessary
  • Move RandomAccessCallbackWrapper to outer class for better readability and because it has it's own responsibility
  • Use Hilt for DI

@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jul 18, 2024
@rfc2822 rfc2822 self-assigned this Jul 18, 2024
@rfc2822 rfc2822 marked this pull request as ready for review July 18, 2024 11:22
@rfc2822 rfc2822 requested a review from sunkup July 18, 2024 11:27
@rfc2822 rfc2822 merged commit 5c4d697 into main-ose Jul 19, 2024
12 checks passed
@rfc2822 rfc2822 deleted the webdav-cache-guava branch July 19, 2024 09:59
@rfc2822 rfc2822 removed the request for review from sunkup July 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant