Fix: Syncer synchronizes only once #910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the Syncer not synchronizing anymore after the first initial sync.
For more see #909
Short description
In #881 we used the same hashmap (
remoteCalendars
,remoteAddressbooks
, ...) for supplying collections to the sync manager and to determine whether a new local resource (calendar, address book, task list, jtx collection) should be created for a new found remote collection. This PR introduces a second hashmap (newCollections
), copying from the initial one (remoteCollections
) to determine new remote collections by subtraction. The original hashmap (remoteCollections
) will then be used to provide the collection to the sync manager when syncing.This PR will also close the acquired provider in the abstract syncer, which was forgotten in #881.
remoteCollections
newCollections
to determine new remote collectionsnewCollections
remoteCollections
to provide collections when syncing to sync manager.Checklist