Skip to content

Rewrite WelcomeFragment to Compose #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2024
Merged

Rewrite WelcomeFragment to Compose #582

merged 2 commits into from
Feb 28, 2024

Conversation

ArnyminerZ
Copy link
Member

No description provided.

@ArnyminerZ
Migrated to Jetpack Compose
74191e2 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ self-assigned this Feb 19, 2024
@ArnyminerZ ArnyminerZ linked an issue Feb 19, 2024 that may be closed by this pull request
Rewrite WelcomeFragment to Compose #577
Closed
@ArnyminerZ ArnyminerZ marked this pull request as ready for review February 19, 2024 12:59
@ArnyminerZ ArnyminerZ requested a review from rfc2822 February 19, 2024 12:59
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Feb 28, 2024
rfc2822
rfc2822 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry that I had to remove the animations – I didn't understand them and I want to keep it as simple as possible, because there's still much to do in rewriting to Compose ;)

@rfc2822 rfc2822 merged commit e24543a into dev-ose Feb 28, 2024
@rfc2822 rfc2822 deleted the 577-rewrite-welcomefragment-to-compose branch February 28, 2024 16:35
@ArnyminerZ
Copy link
Member Author

I am sorry that I had to remove the animations

Yeah, don't worry. I just added them because they were there on the XML 😅

I didn't understand them and I want to keep it as simple as possible

They are a bit hard to comprehend, they mix states a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite WelcomeFragment to Compose
2 participants
@ArnyminerZ @rfc2822