-
-
Notifications
You must be signed in to change notification settings - Fork 90
Remove concept of main accounts #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
SyncManager
: take fields directly from collectionSyncManager
: take fields directly from DB collection
This PR/issue depends on: |
SyncManager
: take fields directly from DB collection
This is harder than I anticipated, because LocalAddressBook extends AndroidAddressBook which is tied to an account (of course) and so has a field called "account" already. The name "mainAccount" is quite descriptive ... |
Yes, but we shouldn't need it anymore, but use the collection ID as identifier instead. So DB: collection with ID (belongs to service and account, but that shall not matter in this context anymore) ↔ LocalAddressbook with ID (association via ID) ↔ address book account (not related to main account anymore, but to the ID instead) |
Since the sync is being performed with workers instead of the Sync Adapter Framework, the concept of a "main account" for address book accounts has become obsolete.
We still need address book accounts for storing address books, but they are no longer required to be tied to a "main" account and could from now on exist on their own.
We should remove the concept of a "main" account as much as possible and maybe deprecate it where too hard to remove right now.
Depends on #875
Depends on bitfireAT/davx5#603
The text was updated successfully, but these errors were encountered: