Skip to content

[qa] wallet: Check if maintenance changes the balance #7229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2016
Merged

[qa] wallet: Check if maintenance changes the balance #7229

merged 3 commits into from
Jan 7, 2016

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 18, 2015

Takes about 13 seconds on my system so one could argue to put this into extended.

MarcoFalke added 2 commits December 18, 2015 12:37
[qa] Cleanup wallet.py test
fa0765d 
* Remove outdated comment
* Remove unneeded 0s
* Remove semicolons
[qa] check if wallet or blochchain maintenance changes the balance
fa14d99
@maflcko
Copy link
Member Author

maflcko commented Dec 18, 2015

Looks like there is a bug with lock order: #7231

@maflcko maflcko mentioned this pull request Dec 19, 2015
Closed
@laanwj
Copy link
Member

laanwj commented Jan 7, 2016

utACK

@laanwj laanwj merged commit fa33d97 into bitcoin:master Jan 7, 2016
laanwj added a commit that referenced this pull request Jan 7, 2016
@laanwj
Merge pull request #7229
d964b5b 
fa33d97 [walletdb] Add missing LOCK() in Recover() for dummyWallet (MarcoFalke)
fa14d99 [qa] check if wallet or blochchain maintenance changes the balance (MarcoFalke)
fa0765d [qa] Cleanup wallet.py test (MarcoFalke)
laanwj pushed a commit that referenced this pull request Jan 7, 2016
@laanwj
[qa] wallet: Check if maintenance changes the balance
1ed938b 
- [qa] Cleanup wallet.py test
- [qa] check if wallet or blochchain maintenance changes the balance
- [walletdb] Add missing LOCK() in Recover() for dummyWallet

Github-Pull: #7229
Rebased-From: fa0765d fa14d99 fa33d97
@maflcko maflcko deleted the MarcoFalke-2015-rpcWalletMaintenance branch January 7, 2016 11:34
@dagurval dagurval mentioned this pull request Jan 17, 2018
Merged
@LarryRuane LarryRuane mentioned this pull request Feb 18, 2021
Merged
LarryRuane pushed a commit to LarryRuane/zcash that referenced this pull request Feb 19, 2021
@LarryRuane
[walletdb] Add missing LOCK() in Recover() for dummyWallet
4359b3b 
zcash: cherry picked fa33d97
zcash: bitcoin/bitcoin#7229
zkbot added a commit to zcash/zcash that referenced this pull request Feb 19, 2021
@zkbot
Auto merge of #4992 - LarryRuane:upstream-locking-0.11, r=str4d
b08c673 
Bitcoin 0.12 locking PRs

These are locking changes from upstream (bitcoin core) release 0.12.

- bitcoin/bitcoin#7013
- bitcoin/bitcoin#7156
- bitcoin/bitcoin#7229
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maflcko @laanwj @jonasschnelli