This repository was archived by the owner on Jun 17, 2022. It is now read-only.
Declare single-argument (non-converting) constructors "explicit" #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid unintended implicit conversions. Cherry-picked from 64fb0ac016c7fd01c60c39af60f6431bac57f9ee
|
Probably needs rebase now that #4 is merged to reduce the commit list? |
|
Done |
|
utACK fe805ea |
|
utACK fe805ea. |
laanwj
added a commit
that referenced
this pull request
Oct 11, 2017
…icit" fe805ea Declare single-argument (non-converting) constructors "explicit" (practicalswift) Pull request description: Rebased on #4. Closes #6, which stripped the original author. Tree-SHA512: 4f4164fb1bbce54e5e28a5cf1327c4d7a2058e74384d1173de843acbfb71a3dc4a11e559650b86c6ac9063ea9c76c96fa371bff985d794c8dc904448f4ecd095
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #4.
Closes #6, which stripped the original author.