Invoke capnp compile from mpgen #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanofsky
added a commit
that referenced
this pull request
Aug 6, 2019
f89e4b3 Invoke capnp compile from mpgen (Russell Yanofsky) Pull request description: This simplifies multiprocess build code somewhat (bitcoin/bitcoin#16367) so it only has to invoke one code generator instead of two, and is probably a little more future proof in that is should make it possible to change capnp options without any requiring changes outside libmultiprocess. Top commit has no ACKs. Tree-SHA512: 64534ec8d020eaf6a2dd351e4e48bf3a7a9897c126db1585c259950070b513aa9a416204e64ad1ab16717f41c534b9aafced4844039ed1f9037550946533445e
|
A commit from the future:
😃 |
Yeah, I messed this up, and there isn't a good way to fix it without rewriting all the hashes in commit history. Could do if I find a convenient tool that does this. |
hebasto
reviewed
Sep 16, 2022
| @@ -475,13 +524,13 @@ void Generate(kj::StringPtr output_stem, kj::StringPtr input_schema, kj::ArrayPt | |||
| int main(int argc, char** argv) | |||
| { | |||
| if (argc < 3) { | |||
| fprintf(stderr, "Usage: " PROXY_BIN " OUTPUT_STEM INPUT_SCHEMA [IMPORT_PATH...]\n"); | |||
| fprintf(stderr, "Usage: " PROXY_BIN " SRC_PREFIX SRC_FILE [IMPORT_PATH...]\n"); | |||
There was a problem hiding this comment.
Should it be
- fprintf(stderr, "Usage: " PROXY_BIN " SRC_PREFIX SRC_FILE [IMPORT_PATH...]\n");
+ fprintf(stderr, "Usage: " PROXY_BIN " SRC_PREFIX INCLUDE_PREFIX SRC_FILE [IMPORT_PATH...]\n");?
There was a problem hiding this comment.
Should it be
Good catch. Should be fixed in #80
ryanofsky
added a commit
to ryanofsky/libmultiprocess
that referenced
this pull request
Sep 19, 2022
Also add comment to describe argument meanings. Problem with string was reported by Hennadii Stepanov <[email protected]> bitcoin-core#9 (comment)
ryanofsky
added a commit
that referenced
this pull request
Sep 19, 2022
fcad5fb doc: Fix mpgen usage string (Ryan Ofsky) Pull request description: Also add comment to describe argument meanings. Problem with string was reported by hebasto in #9 (comment) Top commit has no ACKs. Tree-SHA512: e92c67f3856b175c52471eb2ab3f0d42a98cae843b48e353d2d2be83621bc23eca9e316133b72e7006f63bfe8b4df5e5801859d28863ef94f2c2131b08a8801c
This simplifies multiprocess build code somewhat (bitcoin/bitcoin#16367) so it only has to invoke one code generator instead of two, and is probably a little more future proof in that is should make it possible to change capnp options without any requiring changes outside libmultiprocess.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies multiprocess build code somewhat (bitcoin/bitcoin#16367) so it only has to invoke one code generator instead of two, and is probably a little more future proof in that is should make it possible to change capnp options without any requiring changes outside libmultiprocess.