Skip to content

ci: have bash scripts explicitly opt out of locale dependence. #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2025
Merged

ci: have bash scripts explicitly opt out of locale dependence. #187

merged 3 commits into from
Jun 27, 2025

Conversation

Sjors
Copy link
Member

@Sjors Sjors commented Jun 27, 2025 •
edited
Loading

Prevents linter issues like reported here: Sjors/bitcoin#90 (comment)

But probably also just a good idea.

Also make the use of #!/usr/bin/env bash consistent and added a copyright header (mostly for aesthetic reasons).

@DrahtBot
Copy link

DrahtBot commented Jun 27, 2025 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK ryanofsky

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

ryanofsky
ryanofsky approved these changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK fefee4b. This looks fine, and thanks for the fix! I did suggest some tweaks to consider, but this also looks ok as is

Sjors added 2 commits June 27, 2025 17:02
@Sjors
ci: export LC_ALL
e956467 
Explicitly opt out of locale dependence.
@Sjors
ci: add copyright to bash scripts
401e0ce
@Sjors
Copy link
Member Author

Sjors commented Jun 27, 2025

I dropped copyright and locale from ci/configs, and renamed them to .bash.

@Sjors
ci: rename configs to .bash
3a6db38 
Avoids locale linting error and indicates that the config files
must use bash, not some other variant of shell script.
@Sjors
Copy link
Member Author

Sjors commented Jun 27, 2025 •
edited
Loading

I didn't test if the new push actually satisfies the linter. Will test that again along with other changes (when they're made).

ryanofsky
ryanofsky reviewed Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 3a6db38. Thanks!

I assumed renaming should fix the lint issues based on the *.sh glob pattern in test/lint/lint-shell-locale.py, but will see. Will merge this shortly.

@ryanofsky ryanofsky merged commit c0efaa5 into bitcoin-core:master Jun 27, 2025
3 checks passed
Sjors added a commit to Sjors/bitcoin that referenced this pull request Jun 28, 2025
@Sjors
Squashed 'src/ipc/libmultiprocess/' changes from 258a617c1e..258b83cdba
74e21e9 
258b83cdba proxy-io: fix race conditions in disconnect callback code
f01867805e proxy-io: fix race conditions in ProxyClientBase cleanup handler
6f72e105da refactor: Rename ProxyClient cleanup_it variable
3b138eca55 refactor: rename ProxyClient<Thread>::m_cleanup_it
266c7446e2 mptest: fix race condition in TestSetup constructor
54f3e3b61c ci: add thread sanitizer job
c0efaa5e8c Merge bitcoin-core/libmultiprocess#187: ci: have bash scripts explicitly opt out of locale dependence.
3a6db38e56 ci: rename configs to .bash
401e0ce1d9 ci: add copyright to bash scripts
e956467ae4 ci: export LC_ALL
8954cc0377 Merge bitcoin-core/libmultiprocess#184: Add CI jobs and fix clang-tidy and iwyu errors
757e13a755 ci: add gnu32 cross-compiled 32-bit build
15bf349000 doc: fix typo found by DrahtBot
1a598d5905 clang-tidy: drop 'bitcoin-*' check
cbb1e43fdc ci: test libc++ instead of libstdc++ in one job
76313450c2 type-context: disable clang-tidy UndefinedBinaryOperatorResult error
4896e7fe51 proxy-types: fix clang-tidy EnumCastOutOfRange error
060a739269 proxy-types: fix clang-tidy StackAddressEscape error
977d721020 ci: add github actions jobs testing gcc, clang-20, clang-tidy, and iwyu
0d5f1faae5 iwyu: fix add/remove include errors
753d2b10cc util: fix clang-tidy modernize-use-equals-default error
ae4f1dc2bb type-number: fix clang-tidy modernize-use-nullptr error
07a741bf69 proxy-types: fix clang-tidy bugprone-use-after-move error
3673114bc9 proxy-types: fix clang-tidy bugprone-use-after-move error
422923f384 proxy-types: fix clang-tidy bugprone-use-after-move error
c6784c6ade mpgen: disable clang-tidy misc-no-recursion error
c5498aa11b tidy: copy clang-tidy file from bitcoin core

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: 258b83cdbae0cd13a98a95bc12117caf216d4993
Sjors added a commit to Sjors/bitcoin that referenced this pull request Jun 30, 2025
@Sjors
Squashed 'src/ipc/libmultiprocess/' changes from 258a617c1e..71d3107ad2
c909d3c 
71d3107ad2 proxy-io: fix race conditions in disconnect callback code
f21798df80 proxy-io: fix race conditions in ProxyClientBase cleanup handler
81dca45f08 doc: Add note about Waiter::m_mutex and interaction with the EventLoop::m_mutex
b0a2b54f99 refactor: Rename ProxyClient cleanup_it variable
8806d06c8f refactor: rename ProxyClient<Thread>::m_cleanup_it
266c7446e2 mptest: fix race condition in TestSetup constructor
54f3e3b61c ci: add thread sanitizer job
c0efaa5e8c Merge bitcoin-core/libmultiprocess#187: ci: have bash scripts explicitly opt out of locale dependence.
3a6db38e56 ci: rename configs to .bash
401e0ce1d9 ci: add copyright to bash scripts
e956467ae4 ci: export LC_ALL
8954cc0377 Merge bitcoin-core/libmultiprocess#184: Add CI jobs and fix clang-tidy and iwyu errors
757e13a755 ci: add gnu32 cross-compiled 32-bit build
15bf349000 doc: fix typo found by DrahtBot
1a598d5905 clang-tidy: drop 'bitcoin-*' check
cbb1e43fdc ci: test libc++ instead of libstdc++ in one job
76313450c2 type-context: disable clang-tidy UndefinedBinaryOperatorResult error
4896e7fe51 proxy-types: fix clang-tidy EnumCastOutOfRange error
060a739269 proxy-types: fix clang-tidy StackAddressEscape error
977d721020 ci: add github actions jobs testing gcc, clang-20, clang-tidy, and iwyu
0d5f1faae5 iwyu: fix add/remove include errors
753d2b10cc util: fix clang-tidy modernize-use-equals-default error
ae4f1dc2bb type-number: fix clang-tidy modernize-use-nullptr error
07a741bf69 proxy-types: fix clang-tidy bugprone-use-after-move error
3673114bc9 proxy-types: fix clang-tidy bugprone-use-after-move error
422923f384 proxy-types: fix clang-tidy bugprone-use-after-move error
c6784c6ade mpgen: disable clang-tidy misc-no-recursion error
c5498aa11b tidy: copy clang-tidy file from bitcoin core

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: 71d3107ad2b7d1a275302e239caac97e9a6d1228
Sjors added a commit to Sjors/bitcoin that referenced this pull request Jun 30, 2025
@Sjors
Squashed 'src/ipc/libmultiprocess/' changes from 258a617c1e..71d3107ad2
134a57a 
71d3107ad2 proxy-io: fix race conditions in disconnect callback code
f21798df80 proxy-io: fix race conditions in ProxyClientBase cleanup handler
81dca45f08 doc: Add note about Waiter::m_mutex and interaction with the EventLoop::m_mutex
b0a2b54f99 refactor: Rename ProxyClient cleanup_it variable
8806d06c8f refactor: rename ProxyClient<Thread>::m_cleanup_it
266c7446e2 mptest: fix race condition in TestSetup constructor
54f3e3b61c ci: add thread sanitizer job
c0efaa5e8c Merge bitcoin-core/libmultiprocess#187: ci: have bash scripts explicitly opt out of locale dependence.
3a6db38e56 ci: rename configs to .bash
401e0ce1d9 ci: add copyright to bash scripts
e956467ae4 ci: export LC_ALL
8954cc0377 Merge bitcoin-core/libmultiprocess#184: Add CI jobs and fix clang-tidy and iwyu errors
757e13a755 ci: add gnu32 cross-compiled 32-bit build
15bf349000 doc: fix typo found by DrahtBot
1a598d5905 clang-tidy: drop 'bitcoin-*' check
cbb1e43fdc ci: test libc++ instead of libstdc++ in one job
76313450c2 type-context: disable clang-tidy UndefinedBinaryOperatorResult error
4896e7fe51 proxy-types: fix clang-tidy EnumCastOutOfRange error
060a739269 proxy-types: fix clang-tidy StackAddressEscape error
977d721020 ci: add github actions jobs testing gcc, clang-20, clang-tidy, and iwyu
0d5f1faae5 iwyu: fix add/remove include errors
753d2b10cc util: fix clang-tidy modernize-use-equals-default error
ae4f1dc2bb type-number: fix clang-tidy modernize-use-nullptr error
07a741bf69 proxy-types: fix clang-tidy bugprone-use-after-move error
3673114bc9 proxy-types: fix clang-tidy bugprone-use-after-move error
422923f384 proxy-types: fix clang-tidy bugprone-use-after-move error
c6784c6ade mpgen: disable clang-tidy misc-no-recursion error
c5498aa11b tidy: copy clang-tidy file from bitcoin core

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: 71d3107ad2b7d1a275302e239caac97e9a6d1228
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Jul 1, 2025
@ryanofsky
Squashed 'src/ipc/libmultiprocess/' changes from 27c7e8e5a581..725bee…
96bcbb6 
…adc9ae

725beeadc9ae doc: fix DrahtBot LLM Linter error
7455fc0e3781 type-context: revert client disconnect workaround
47f052c3ed94 proxy-types: fix UndefinedBehaviorSanitizer: null-pointer-use
f6bd4385c057 mptest: fix MemorySanitizer: use-of-uninitialized-value
8218a1d8760d proxy-io: fix race conditions in disconnect callback code
88695fc05303 proxy-io: fix race conditions in ProxyClientBase cleanup handler
63bd2a201dc2 doc: Add note about Waiter::m_mutex and interaction with the EventLoop::m_mutex
81d58f5580e8 refactor: Rename ProxyClient cleanup_it variable
07230f259f55 refactor: rename ProxyClient<Thread>::m_cleanup_it
0d986ff144cd mptest: fix race condition in TestSetup constructor
d2f6aa2e84ef ci: add thread sanitizer job
c0efaa5e8cb1 Merge bitcoin-core/libmultiprocess#187: ci: have bash scripts explicitly opt out of locale dependence.
3a6db38e561f ci: rename configs to .bash
401e0ce1d9c3 ci: add copyright to bash scripts
e956467ae464 ci: export LC_ALL
8954cc0377d8 Merge bitcoin-core/libmultiprocess#184: Add CI jobs and fix clang-tidy and iwyu errors
757e13a75546 ci: add gnu32 cross-compiled 32-bit build
15bf349000eb doc: fix typo found by DrahtBot
1a598d5905f7 clang-tidy: drop 'bitcoin-*' check
cbb1e43fdc6e ci: test libc++ instead of libstdc++ in one job
76313450c2c4 type-context: disable clang-tidy UndefinedBinaryOperatorResult error
4896e7fe51ba proxy-types: fix clang-tidy EnumCastOutOfRange error
060a73926956 proxy-types: fix clang-tidy StackAddressEscape error
977d721020f6 ci: add github actions jobs testing gcc, clang-20, clang-tidy, and iwyu
0d5f1faae5da iwyu: fix add/remove include errors
753d2b10cc27 util: fix clang-tidy modernize-use-equals-default error
ae4f1dc2bb1a type-number: fix clang-tidy modernize-use-nullptr error
07a741bf6946 proxy-types: fix clang-tidy bugprone-use-after-move error
3673114bc9d9 proxy-types: fix clang-tidy bugprone-use-after-move error
422923f38485 proxy-types: fix clang-tidy bugprone-use-after-move error
c6784c6adefa mpgen: disable clang-tidy misc-no-recursion error
c5498aa11ba6 tidy: copy clang-tidy file from bitcoin core
258a617c1eec Merge bitcoin-core/libmultiprocess#160: refactor: EventLoop locking cleanups + client disconnect exception
84cf56a0b5f4 test: Test disconnects during IPC calls
949573da8411 Prevent IPC server crash if disconnected during IPC call
019839758085 Merge bitcoin-core/libmultiprocess#179: scripted-diff: Remove copyright year (ranges)
ea38392960e1 Prevent EventLoop async cleanup thread early exit during shutdown
616d9a75d20a doc: Document ProxyClientBase destroy_connection option
56fff76f940b Improve IPC client disconnected exceptions
9b8ed3dc5f87 refactor: Add clang thread safety annotations to EventLoop
52256e730f51 refactor: Remove DestructorCatcher and AsyncCallable
f24894794adf refactor: Drop addClient/removeClient methods
2b830e558e61 refactor: Use EventLoopRef instead of addClient/removeClient
315ff537fb65 refactor: Add ProxyContext EventLoop* member
9aaeec3678d3 proxy-io.h: Add EventLoopRef RAII class handle addClient/removeClient refcounting
f58c8d8ba2f0 proxy-io.h: Add more detailed EventLoop comment
5108445e5d16 test: Add test coverage for client & server disconnections
59030c68cb5f Merge bitcoin-core/libmultiprocess#181: type-function.h: Fix CustomBuildField overload
688140b1dffc test: Add coverage for type-function.h
8b96229da58e type-function.h: Fix CustomBuildField overload
fa2ff9a66842 scripted-diff: Remove copyright year (ranges)

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: 725beeadc9ae30664aa3ed12a9ac2b77a9d8d4e0
@ryanofsky ryanofsky mentioned this pull request Jul 1, 2025
Open
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Jul 1, 2025
@ryanofsky
Squashed 'src/ipc/libmultiprocess/' changes from 27c7e8e5a581..6f340a…
6e40719 
…583f2b

6f340a583f2b doc: fix DrahtBot LLM Linter error
c6f7fdf17350 type-context: revert client disconnect workaround
e09143d2ea2f proxy-types: fix UndefinedBehaviorSanitizer: null-pointer-use
84b292fcc4db mptest: fix MemorySanitizer: use-of-uninitialized-value
fe4a188803c6 proxy-io: fix race conditions in disconnect callback code
d8011c83608e proxy-io: fix race conditions in ProxyClientBase cleanup handler
97e82ce19c47 doc: Add note about Waiter::m_mutex and interaction with the EventLoop::m_mutex
81d58f5580e8 refactor: Rename ProxyClient cleanup_it variable
07230f259f55 refactor: rename ProxyClient<Thread>::m_cleanup_it
0d986ff144cd mptest: fix race condition in TestSetup constructor
d2f6aa2e84ef ci: add thread sanitizer job
c0efaa5e8cb1 Merge bitcoin-core/libmultiprocess#187: ci: have bash scripts explicitly opt out of locale dependence.
3a6db38e561f ci: rename configs to .bash
401e0ce1d9c3 ci: add copyright to bash scripts
e956467ae464 ci: export LC_ALL
8954cc0377d8 Merge bitcoin-core/libmultiprocess#184: Add CI jobs and fix clang-tidy and iwyu errors
757e13a75546 ci: add gnu32 cross-compiled 32-bit build
15bf349000eb doc: fix typo found by DrahtBot
1a598d5905f7 clang-tidy: drop 'bitcoin-*' check
cbb1e43fdc6e ci: test libc++ instead of libstdc++ in one job
76313450c2c4 type-context: disable clang-tidy UndefinedBinaryOperatorResult error
4896e7fe51ba proxy-types: fix clang-tidy EnumCastOutOfRange error
060a73926956 proxy-types: fix clang-tidy StackAddressEscape error
977d721020f6 ci: add github actions jobs testing gcc, clang-20, clang-tidy, and iwyu
0d5f1faae5da iwyu: fix add/remove include errors
753d2b10cc27 util: fix clang-tidy modernize-use-equals-default error
ae4f1dc2bb1a type-number: fix clang-tidy modernize-use-nullptr error
07a741bf6946 proxy-types: fix clang-tidy bugprone-use-after-move error
3673114bc9d9 proxy-types: fix clang-tidy bugprone-use-after-move error
422923f38485 proxy-types: fix clang-tidy bugprone-use-after-move error
c6784c6adefa mpgen: disable clang-tidy misc-no-recursion error
c5498aa11ba6 tidy: copy clang-tidy file from bitcoin core
258a617c1eec Merge bitcoin-core/libmultiprocess#160: refactor: EventLoop locking cleanups + client disconnect exception
84cf56a0b5f4 test: Test disconnects during IPC calls
949573da8411 Prevent IPC server crash if disconnected during IPC call
019839758085 Merge bitcoin-core/libmultiprocess#179: scripted-diff: Remove copyright year (ranges)
ea38392960e1 Prevent EventLoop async cleanup thread early exit during shutdown
616d9a75d20a doc: Document ProxyClientBase destroy_connection option
56fff76f940b Improve IPC client disconnected exceptions
9b8ed3dc5f87 refactor: Add clang thread safety annotations to EventLoop
52256e730f51 refactor: Remove DestructorCatcher and AsyncCallable
f24894794adf refactor: Drop addClient/removeClient methods
2b830e558e61 refactor: Use EventLoopRef instead of addClient/removeClient
315ff537fb65 refactor: Add ProxyContext EventLoop* member
9aaeec3678d3 proxy-io.h: Add EventLoopRef RAII class handle addClient/removeClient refcounting
f58c8d8ba2f0 proxy-io.h: Add more detailed EventLoop comment
5108445e5d16 test: Add test coverage for client & server disconnections
59030c68cb5f Merge bitcoin-core/libmultiprocess#181: type-function.h: Fix CustomBuildField overload
688140b1dffc test: Add coverage for type-function.h
8b96229da58e type-function.h: Fix CustomBuildField overload
fa2ff9a66842 scripted-diff: Remove copyright year (ranges)

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: 6f340a583f2b29b32866c289d5f4d7662b4fe90e
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Jul 1, 2025
@ryanofsky
Squashed 'src/ipc/libmultiprocess/' changes from 27c7e8e5a581..a11e69…
ca509dd 
…05c238

a11e6905c238 Merge bitcoin-core/libmultiprocess#186: Fix mptest failures in bitcoin CI
6f340a583f2b doc: fix DrahtBot LLM Linter error
c6f7fdf17350 type-context: revert client disconnect workaround
e09143d2ea2f proxy-types: fix UndefinedBehaviorSanitizer: null-pointer-use
84b292fcc4db mptest: fix MemorySanitizer: use-of-uninitialized-value
fe4a188803c6 proxy-io: fix race conditions in disconnect callback code
d8011c83608e proxy-io: fix race conditions in ProxyClientBase cleanup handler
97e82ce19c47 doc: Add note about Waiter::m_mutex and interaction with the EventLoop::m_mutex
81d58f5580e8 refactor: Rename ProxyClient cleanup_it variable
07230f259f55 refactor: rename ProxyClient<Thread>::m_cleanup_it
c0efaa5e8cb1 Merge bitcoin-core/libmultiprocess#187: ci: have bash scripts explicitly opt out of locale dependence.
0d986ff144cd mptest: fix race condition in TestSetup constructor
d2f6aa2e84ef ci: add thread sanitizer job
3a6db38e561f ci: rename configs to .bash
401e0ce1d9c3 ci: add copyright to bash scripts
e956467ae464 ci: export LC_ALL
8954cc0377d8 Merge bitcoin-core/libmultiprocess#184: Add CI jobs and fix clang-tidy and iwyu errors
757e13a75546 ci: add gnu32 cross-compiled 32-bit build
15bf349000eb doc: fix typo found by DrahtBot
1a598d5905f7 clang-tidy: drop 'bitcoin-*' check
cbb1e43fdc6e ci: test libc++ instead of libstdc++ in one job
76313450c2c4 type-context: disable clang-tidy UndefinedBinaryOperatorResult error
4896e7fe51ba proxy-types: fix clang-tidy EnumCastOutOfRange error
060a73926956 proxy-types: fix clang-tidy StackAddressEscape error
977d721020f6 ci: add github actions jobs testing gcc, clang-20, clang-tidy, and iwyu
0d5f1faae5da iwyu: fix add/remove include errors
753d2b10cc27 util: fix clang-tidy modernize-use-equals-default error
ae4f1dc2bb1a type-number: fix clang-tidy modernize-use-nullptr error
07a741bf6946 proxy-types: fix clang-tidy bugprone-use-after-move error
3673114bc9d9 proxy-types: fix clang-tidy bugprone-use-after-move error
422923f38485 proxy-types: fix clang-tidy bugprone-use-after-move error
c6784c6adefa mpgen: disable clang-tidy misc-no-recursion error
c5498aa11ba6 tidy: copy clang-tidy file from bitcoin core
258a617c1eec Merge bitcoin-core/libmultiprocess#160: refactor: EventLoop locking cleanups + client disconnect exception
84cf56a0b5f4 test: Test disconnects during IPC calls
949573da8411 Prevent IPC server crash if disconnected during IPC call
019839758085 Merge bitcoin-core/libmultiprocess#179: scripted-diff: Remove copyright year (ranges)
ea38392960e1 Prevent EventLoop async cleanup thread early exit during shutdown
616d9a75d20a doc: Document ProxyClientBase destroy_connection option
56fff76f940b Improve IPC client disconnected exceptions
9b8ed3dc5f87 refactor: Add clang thread safety annotations to EventLoop
52256e730f51 refactor: Remove DestructorCatcher and AsyncCallable
f24894794adf refactor: Drop addClient/removeClient methods
2b830e558e61 refactor: Use EventLoopRef instead of addClient/removeClient
315ff537fb65 refactor: Add ProxyContext EventLoop* member
9aaeec3678d3 proxy-io.h: Add EventLoopRef RAII class handle addClient/removeClient refcounting
f58c8d8ba2f0 proxy-io.h: Add more detailed EventLoop comment
5108445e5d16 test: Add test coverage for client & server disconnections
59030c68cb5f Merge bitcoin-core/libmultiprocess#181: type-function.h: Fix CustomBuildField overload
688140b1dffc test: Add coverage for type-function.h
8b96229da58e type-function.h: Fix CustomBuildField overload
fa2ff9a66842 scripted-diff: Remove copyright year (ranges)

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: a11e6905c238dc35a8bbef995190296bc6329d49
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Aug 8, 2025
@ryanofsky
Squashed 'src/ipc/libmultiprocess/' changes from 27c7e8e5a581..b4120d…
e886c65 
…34bad2

b4120d34bad2 Merge bitcoin-core/libmultiprocess#192: doc: fix typos
6ecbdcd35a93 doc: fix typos
a11e6905c238 Merge bitcoin-core/libmultiprocess#186: Fix mptest failures in bitcoin CI
6f340a583f2b doc: fix DrahtBot LLM Linter error
c6f7fdf17350 type-context: revert client disconnect workaround
e09143d2ea2f proxy-types: fix UndefinedBehaviorSanitizer: null-pointer-use
84b292fcc4db mptest: fix MemorySanitizer: use-of-uninitialized-value
fe4a188803c6 proxy-io: fix race conditions in disconnect callback code
d8011c83608e proxy-io: fix race conditions in ProxyClientBase cleanup handler
97e82ce19c47 doc: Add note about Waiter::m_mutex and interaction with the EventLoop::m_mutex
81d58f5580e8 refactor: Rename ProxyClient cleanup_it variable
07230f259f55 refactor: rename ProxyClient<Thread>::m_cleanup_it
c0efaa5e8cb1 Merge bitcoin-core/libmultiprocess#187: ci: have bash scripts explicitly opt out of locale dependence.
0d986ff144cd mptest: fix race condition in TestSetup constructor
d2f6aa2e84ef ci: add thread sanitizer job
3a6db38e561f ci: rename configs to .bash
401e0ce1d9c3 ci: add copyright to bash scripts
e956467ae464 ci: export LC_ALL
8954cc0377d8 Merge bitcoin-core/libmultiprocess#184: Add CI jobs and fix clang-tidy and iwyu errors
757e13a75546 ci: add gnu32 cross-compiled 32-bit build
15bf349000eb doc: fix typo found by DrahtBot
1a598d5905f7 clang-tidy: drop 'bitcoin-*' check
cbb1e43fdc6e ci: test libc++ instead of libstdc++ in one job
76313450c2c4 type-context: disable clang-tidy UndefinedBinaryOperatorResult error
4896e7fe51ba proxy-types: fix clang-tidy EnumCastOutOfRange error
060a73926956 proxy-types: fix clang-tidy StackAddressEscape error
977d721020f6 ci: add github actions jobs testing gcc, clang-20, clang-tidy, and iwyu
0d5f1faae5da iwyu: fix add/remove include errors
753d2b10cc27 util: fix clang-tidy modernize-use-equals-default error
ae4f1dc2bb1a type-number: fix clang-tidy modernize-use-nullptr error
07a741bf6946 proxy-types: fix clang-tidy bugprone-use-after-move error
3673114bc9d9 proxy-types: fix clang-tidy bugprone-use-after-move error
422923f38485 proxy-types: fix clang-tidy bugprone-use-after-move error
c6784c6adefa mpgen: disable clang-tidy misc-no-recursion error
c5498aa11ba6 tidy: copy clang-tidy file from bitcoin core
258a617c1eec Merge bitcoin-core/libmultiprocess#160: refactor: EventLoop locking cleanups + client disconnect exception
84cf56a0b5f4 test: Test disconnects during IPC calls
949573da8411 Prevent IPC server crash if disconnected during IPC call
019839758085 Merge bitcoin-core/libmultiprocess#179: scripted-diff: Remove copyright year (ranges)
ea38392960e1 Prevent EventLoop async cleanup thread early exit during shutdown
616d9a75d20a doc: Document ProxyClientBase destroy_connection option
56fff76f940b Improve IPC client disconnected exceptions
9b8ed3dc5f87 refactor: Add clang thread safety annotations to EventLoop
52256e730f51 refactor: Remove DestructorCatcher and AsyncCallable
f24894794adf refactor: Drop addClient/removeClient methods
2b830e558e61 refactor: Use EventLoopRef instead of addClient/removeClient
315ff537fb65 refactor: Add ProxyContext EventLoop* member
9aaeec3678d3 proxy-io.h: Add EventLoopRef RAII class handle addClient/removeClient refcounting
f58c8d8ba2f0 proxy-io.h: Add more detailed EventLoop comment
5108445e5d16 test: Add test coverage for client & server disconnections
59030c68cb5f Merge bitcoin-core/libmultiprocess#181: type-function.h: Fix CustomBuildField overload
688140b1dffc test: Add coverage for type-function.h
8b96229da58e type-function.h: Fix CustomBuildField overload
fa2ff9a66842 scripted-diff: Remove copyright year (ranges)

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: b4120d34bad2de28141c5770f6e8df8e54898987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanofsky ryanofsky ryanofsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sjors @DrahtBot @ryanofsky