Skip to content

perf: shrink Text #6946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

perf: shrink Text #6946

merged 1 commit into from
Jul 21, 2025

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Jul 19, 2025

Summary

Shrinks Text from 24 bytes to 16. Given that Text is getting used increasingly, including quite pervasively inside the module graph, I figured it might be a good candidate to squeeze a bit further.

Seems to give a ~1-3% improvement on the module graph benchmarks.

Test Plan

Everything should stay green.

Copy link

changeset-bot bot commented Jul 19, 2025

⚠️ No Changeset found

Latest commit: e39d65a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages A-Type-Inference Area: type inference labels Jul 19, 2025
Copy link

codspeed-hq bot commented Jul 20, 2025

CodSpeed Performance Report

Merging #6946 will not alter performance

Comparing arendjr:shrink-text (e39d65a) with main (249306d)

Summary

✅ 115 untouched benchmarks

@arendjr arendjr merged commit 1913dbc into biomejs:main Jul 21, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core Area: core A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Type-Inference Area: type inference L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants