Skip to content

fix(biome_js_analyze): add JsExport to be walked by JsDocTypeCollectorVisitior #6565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
Merged

fix(biome_js_analyze): add JsExport to be walked by JsDocTypeCollectorVisitior #6565

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c41a3b8
Fix visitor to walk on JsExport
daivinhtran Jun 26, 2025
a8caee5
Add changeset
daivinhtran Jun 26, 2025
2c455d8
Update changeset
daivinhtran Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-showers-leave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@biomejs/biome": patch
---

Fixed [4677](https://github.com/biomejs/biome/issues/4677). Now the rule `noUnusedImports` rule won't produce diagnostics for types used in comment of JS_EXPORT
6 changes: 3 additions & 3 deletions crates/biome_js_analyze/src/lint/correctness/no_unused_imports.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ use biome_js_factory::make::{js_identifier_binding, js_module, js_module_item_li
use biome_js_semantic::{ReferencesExtensions, SemanticModel};
use biome_js_syntax::{
AnyJsBinding, AnyJsClassMember, AnyJsCombinedSpecifier, AnyJsDeclaration, AnyJsImportClause,
AnyJsNamedImportSpecifier, AnyTsTypeMember, JsLanguage, JsNamedImportSpecifiers, JsSyntaxNode,
T, TsEnumMember,
AnyJsNamedImportSpecifier, AnyTsTypeMember, JsExport, JsLanguage, JsNamedImportSpecifiers,
JsSyntaxNode, T, TsEnumMember,
};
use biome_jsdoc_comment::JsdocComment;
use biome_rowan::{
Expand Down Expand Up @@ -124,7 +124,7 @@ struct JsDocTypeCollectorVisitior {
}

declare_node_union! {
pub AnyJsWithTypeReferencingJsDoc = AnyJsDeclaration | AnyJsClassMember | AnyTsTypeMember | TsEnumMember
pub AnyJsWithTypeReferencingJsDoc = AnyJsDeclaration | AnyJsClassMember | AnyTsTypeMember | TsEnumMember | JsExport
}

impl Visitor for JsDocTypeCollectorVisitior {
Expand Down
6 changes: 6 additions & 0 deletions crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/issue_4677_jsdoc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import TypeOnClassField from "mod";
import TypeOnGlobalVariable from "mod";
import TypeOnFunctionVariable from "mod";
import TypeOnTypeDef from "mod";
import TypeOnExportedFunction from "mod";

/**
* @typedef {TypeOnTypeDef} TestTypeOnTypeDef
Expand All @@ -18,6 +19,11 @@ import TypeOnTypeDef from "mod";
*/
function testTypeOnFunction(param) {}

/**
* @param {TypeOnExportedFunction} param
*/
export function testTypeOnExportedFunction(param) {}

class TestTypeOnClassMethodParam {
/**
* @param {TypeOnClassMethodParam} param
Expand Down
6 changes: 6 additions & 0 deletions crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/issue_4677_jsdoc.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import TypeOnClassField from "mod";
import TypeOnGlobalVariable from "mod";
import TypeOnFunctionVariable from "mod";
import TypeOnTypeDef from "mod";
import TypeOnExportedFunction from "mod";

/**
* @typedef {TypeOnTypeDef} TestTypeOnTypeDef
Expand All @@ -24,6 +25,11 @@ import TypeOnTypeDef from "mod";
*/
function testTypeOnFunction(param) {}

/**
* @param {TypeOnExportedFunction} param
*/
export function testTypeOnExportedFunction(param) {}

class TestTypeOnClassMethodParam {
/**
* @param {TypeOnClassMethodParam} param
Expand Down
Loading