fix(biome-js-analyze): add a check for if/ else and ternary operators…

[vladimir-ivanov]

Summary

Fixed an issue where class properties that are set in the constructor were not being marked as readonly when they
should be if found in if/ else condition.

Example:

class Price {
 #price: string;

 @Input()
 set some(value: string | number) {
   if (value === undefined || value === null || value === 'undefined' || value === 'null' || Number.isNaN(value)) {
     this.#price = '';
   } else {
     this.#price = '' + value;
   }
 }
}

closes #6500

[changeset-bot]

🦋 Changeset detected

Latest commit: 7ac70fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #6524 will not alter performance

_{Comparing vladimir-ivanov:fix/useReadonlyClassProperties-set-ignored (7ac70fa) with main (a3a3715)}

Summary

✅ 115 untouched benchmarks

[ematipico]

I left some questions around the code, to have more clarity. Also left some comments around the changeset

[ematipico]

Thank you! 👏

[burka]

Yeah great! That works, I tested it on my code :-) Thanks @vladimir-ivanov for that fast fix!