chore(html/formatter): better control over spacing #5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
commented
Apr 8, 2025
| @@ -20,7 +20,7 @@ impl FormatNodeRule<HtmlSelfClosingElement> for FormatHtmlSelfClosingElement { | |||
| let name = name?; | |||
| let is_canonical_html_tag = is_canonical_html_tag(&name); | |||
|
|
|||
| write!(f, [l_angle_token.format(), name.format(), space()])?; | |||
There was a problem hiding this comment.
This space doesn't make a difference, so I removed it
ematipico
commented
Apr 8, 2025
| @@ -6,20 +6,21 @@ snapshot_kind: text | |||
| # Input | |||
|
|
|||
| ```html | |||
| Lorem ipsum<span />dolor sit amet, consectetur adipiscing elit. Sed eu diam vel | |||
There was a problem hiding this comment.
I had to change this example with valid self-closing tags
CodSpeed Performance ReportMerging #5604 will not alter performanceComparing Summary
|
dyc3
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up of #5600 (comment)
We don't print a space after the tag name if it's a void element and there aren't attributes.
Test Plan
Updated the tests