Tool bump #19
Merged
Tool bump #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 11 out of 16 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- .tool-versions: Language not supported
- Dockerfile: Language not supported
- MANIFEST.in: Language not supported
- includes.sh: Language not supported
- requirements.in: Language not supported
Comments suppressed due to low confidence (1)
pyproject.toml:2
- The empty string in backend-path may lead to unresolved module paths. Confirm that an empty string is intentional and works correctly with the new pypi_compatible_build backend.
backend-path = ['']
jamesbraza
reviewed
Apr 17, 2025
| 'django-stubs', | ||
| 'djangorestframework-stubs[compatible-mypy]', | ||
| # hadolint git link in requirements.in | ||
| 'hadolint-py @ git+https://github.com/AleksaC/hadolint-py.git', |
There was a problem hiding this comment.
I like doing this in mypy:
enable_error_code = [
"ignore-without-code",
"mutable-override",
"redundant-cast",
"redundant-expr",
"redundant-self",
"truthy-bool",
"truthy-iterable",
"unimported-reveal",
"unreachable",
"unused-awaitable",
"unused-ignore",
]There was a problem hiding this comment.
Thanks for sharing @jamesbraza. I tried them out.
How would you deal with this?
allowedflare/django.py:80: error: Covariant override of a mutable attribute (base class "TemplateResponseMixin" defined the type as "str | None", expression has type "str") [mutable-override]
Based on some of the discussion in python/mypy#3208 I tried template_name: Final[str] = 'login.html' but that just changed the error to:
allowedflare/django.py:80: error: Cannot override writable attribute "template_name" with a final one [misc]
pypi_compatible_build.py
Outdated
|
|
||
| import setuptools | ||
| from packaging.metadata import Metadata | ||
| from setuptools._core_metadata import _write_requirements # type: ignore[import-untyped] |
There was a problem hiding this comment.
Why do you have this if you have types-setuptools?
There was a problem hiding this comment.
It looks like the stubs don't cover _core_metadata https://github.com/python/typeshed/tree/main/stubs/setuptools/setuptools
jamesbraza
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tooling
Older
twine checkdidn't like newer metadata version 2.4 being generated. Accidentally upgraded everything else.