Skip to content

Fix docker-compose.yaml #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 6, 2025
Merged

Fix docker-compose.yaml #17

merged 8 commits into from
Feb 6, 2025

Conversation

covracer
Copy link
Collaborator

@covracer covracer commented Feb 1, 2025

Background and Links

  • Docker compose file still referenced .venv, but I think that approach was abandoned due to conflicts with volume mount
  • I mostly python -m manage without Docker these days, but I like keeping working Docker images around

Changes and Testing

  • Remove .venv from paths
  • Auto-update boilerplate from upstream

Questions and Followup

  • Node from asdf?
  • Sharing host and container venv? uv cache?

Copy link

@DuncanTormey DuncanTormey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too have slowed down my "all docker all the time" mentality. I feel like it is nice to support docker and venv.

@covracer covracer merged commit 5fd8edb into main Feb 6, 2025
3 checks passed
@covracer covracer deleted the docker-fixes branch February 6, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants