refactor: use async context manager and improve error handling in reverse_proxy #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fazialnjd
changed the title
fazialnjd
force-pushed
the
refactor/reverse-proxy-error-handling
branch
from
689cba7 to
781a08e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor: use async context manager and improve error handling in reverse_proxy
This PR refactors the
reverse_proxyendpoint:async with httpx.AsyncClient()to manage connection lifecycle properly.try/exceptblock to handle request-level errors gracefully.502on proxy errors, and500for unexpected internal failures.404for invalid proxy targets.Motivation
Previously, some proxy requests caused intermittent 500 errors due to unclosed HTTP client sessions or unreachable services. This change improves error handling and stability.
Related Issues
No related issue was created for this change.