feat: provide your own mapbox library/geocoder #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In scenarios where you deploy your own web app, with sveltekit or not, using the window object is fine, since you control everything about the page. However, in browser extensions, we can't expect to populate the window object, since we might collide with the underlying page or other extensions. This PR allows you to Bring Your Own Mapbox, by providing the library directly to the component.
|
An alternative API would be to put the mapbox library in a context, where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scenarios where you deploy your own web app, with sveltekit or not, using the window object is fine, since you control everything about the page.
However, in browser extensions, we can't expect to populate the window object, since we might collide with the underlying page or other extensions. If the versions are mismatched, and you depend on something older or newer than the others, your extension and the page might break in unexpected ways!
This PR allows you to Bring Your Own Mapbox, by providing the library directly to the component. By providing the library yourself, you completely avoid using the
windowobject, which in turn lets the underlying page do whatever it wants without being bothered by your extension.