-
Notifications
You must be signed in to change notification settings - Fork 5
Fonts is not vertically centered #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @indaviande, thanks for the report. |
We are actually open for correcting the vertical metrics so that future users like indaviande can have it work out of the box. I also learnt that present users who are active tend to be able to fix this easily, while inactive users such as ones who used Google Fonts in Figma won't be impacted because Figma cached the layouts. What that works @emmamarichal ? |
Yes I understand, but the font is served almost 10million time and featured on 19000 websites. I would not take the risk to change anything here, even if it's for a better result. It's the inconvenient of fonts served on an API, we can't make any big change without consequences, the rest of my team will not validate this too, I'm very sorry. |
@bettergui @emmamarichal - I'm running into the same issue as @indaviande - would you be able to offer any insights on possible ways to fix this? (Really keen to use Darker Grotesque as the style fits the project perfectly) - would it be permissible / feasible to edit the font file using FontForge or something similar? If so, could you advise which values to adjust to get it vertically centred? |
Hi @ActionWolfMedia! To sum up, you need to do this: Or if you already have TypoAscender and TypoDescender values: Current case:
So, new values are:
|
You can do this, re-export the fonts locally, but we can't push these changes on the API unfortunately |
@emmamarichal - Thanks for your help - much appreciated. |
This new values remove some space above, and add some below, that should balance all the font better. We usually follow the caps values, because a lot of buttons are composed full caps. Please make a test with these new values, you will that it is much better! |
OK, great, thank you. Would you be able to suggest the best way of implementing those value changes? (i.e. is there a programme / platform you'd recommend to use?) - again, not really a font expert, so any guidance there would be really helpful :) |
I can see if I have the time to do a quick hotfix directly on binaries |
@emmamarichal - amazing, thank you! |
@emmamarichal - Sorry to pester you again - would it be easy for you to add a TTF, WOFF & WOFF2 version of the caps centred font in Regular and SemiBold? (I'm adding to a Shopify project, which makes it quite difficult to use a variable weight font)? |
Hi @ActionWolfMedia and @emmamarichal, thank you all for bringing this up. We are the authors of the font and we have plans to do a design overhaul (engineering included) for all of our fonts on GF. So rest assured that we will address this error in the upcoming update. |
Hi @yellow-type-foundry! Thank you for the update :) |
Hi @emmamarichal - thanks for the reply - I've managed to get the variable font working now :) Thanks though, and look forward to the upcoming update that @yellow-type-foundry mentioned. Appreciate the support |
I've noticed that all buttons are misaligned because the font itself is not vertically centered.
If I switch to another font, the issue disappear.
You can better see it on Firefox.
The text was updated successfully, but these errors were encountered: