Skip to content

Add performance improvements to alert comment #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

414owen
Copy link
Contributor

@414owen 414owen commented Feb 11, 2025

Example of improvement: 414owen/outlines-core#5
Example of regression: 414owen/outlines-core#6

Reports can contain both at once, of course.

@ktrz

@414owen 414owen closed this Feb 12, 2025
@414owen 414owen reopened this Feb 12, 2025
@ktrz
Copy link
Member

ktrz commented Mar 12, 2025

hi @414owen
Sorry for taking so long to get back to you!
Thank you for this contribution! As you might see we have failing tests in this PR. Could you please have a look at those and update them to match the new proposed output format? If we are missing tests for the case of improvements please do add them.

@414owen 414owen force-pushed the os/comment-with-successes branch 6 times, most recently from 3500170 to 79f5df5 Compare May 16, 2025 23:21
@414owen
Copy link
Contributor Author

414owen commented May 16, 2025

@ktrz this should be good to review now

Copy link
Member

@ktrz ktrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @414owen !
Could you please also add test cases for when we have both gains and losses as well as one where it doesn't trigger an error if we have only gains?

@414owen 414owen force-pushed the os/comment-with-successes branch from 79f5df5 to 3e7f1f0 Compare May 20, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants