Skip to content

Add multi-field OR filter functionality #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 10, 2025

Conversation

doubledare704
Copy link
Contributor

Pull Request Template for FastCRUD

Description

This PR implements the feature requested in issue #117, adding support for OR conditions across multiple fields in FastCRUD.

Changes

  • Added a new _handle_multi_field_or_filter method to the FastCRUD class to handle OR conditions across multiple fields
  • Updated the _parse_filters method to recognize a special _or parameter for multi-field OR filtering
  • Added comprehensive tests for the new functionality
  • Updated documentation in docs/advanced/filters.md to explain how to use the new feature

Tests

Describe the tests you added or modified to cover your changes, if applicable.

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added necessary documentation (if appropriate).
  • I have added tests that cover my changes (if applicable).
  • All new and existing tests passed.

Additional Notes

Include any additional information that you think is important for reviewers to know.

Copy link
Collaborator

@igorbenav igorbenav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great as always!
Thanks, @doubledare704

@igorbenav igorbenav merged commit c722cb2 into benavlabs:main May 10, 2025
7 checks passed
@doubledare704 doubledare704 deleted the feature/multi-field-or-filter branch May 10, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants