implementing sort for nested fields #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorbenav
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for FastCRUD
Description
Extended crud helper to suport sorting by some fields and with order pick. Added test cases and updated existing tests.
Changes
Solving: #171
sort_columns and sort_orders added to joinconfig
added _sort_nested_list to crud/helper.py
updated _nest_join_data to use new logic
updated conftests
updated tests/sqlalchemy/core/test_nest_multi_join_data.py
Tests
added tests/sqlalchemy/crud/test_sort_nested_relationships.py
Checklist
Additional Notes
Include any additional information that you think is important for reviewers to know.