Implement OR and NOT for filtering. #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doubledare704 can you please just fix the typing issues? |
- Split _parse_filters into smaller, focused helper methods
- Added proper type hints and docstrings for better clarity
- Fixed variable shadowing in column handling
- Improved error handling consistency
- Added dedicated methods for:
- _handle_simple_filter
- _handle_or_filter
- _handle_not_filter
- _handle_standard_filter
- _get_column
Implementation Notes:
- OR operations:
field__or={'gt': 18, 'lt': 65} applies multiple conditions to same field
Example: age__or={'gt': 18, 'lt': 65} -> WHERE age > 18 OR age < 65
- NOT operations:
field__not={'eq': value, 'between': (x,y)} applies NOT to each condition
Example: age__not={'eq': 20, 'between': (30,40)} ->
WHERE NOT age = 20 AND NOT (age BETWEEN 30 AND 40)
Makes the code more maintainable and easier to test by reducing complexity
and improving separation of concerns.
doubledare704
force-pushed
the
feature/Add-support-for-OR-and-AND-conditions-in-filtering
branch
from
b96efd8 to
ff59e11
Compare
|
Great one, @doubledare704, thanks for it! |
igorbenav
approved these changes
Mar 26, 2025
This was referenced Mar 26, 2025
|
@igorbenav seems like types was fixed |
doubledare704
deleted the
feature/Add-support-for-OR-and-AND-conditions-in-filtering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for FastCRUD
Description
refactor: improve FastCRUD filter parsing readability and operations
Implementation Notes:
OR operations: field__or={'gt': 18, 'lt': 65} applies multiple conditions to same field Example: age__or={'gt': 18, 'lt': 65} -> WHERE age > 18 OR age < 65
NOT operations: field__not={'eq': value, 'between': (x,y)} applies NOT to each condition
Example: age__not={'eq': 20, 'between': (30,40)} ->
WHERE NOT age = 20 AND NOT (age BETWEEN 30 AND 40)
Makes the code more maintainable and easier to test by reducing complexity and improving separation of concerns.
Changes
Briefly list the changes you've made. If applicable, also link any relevant issues or pull requests.
Tests
Describe the tests you added or modified to cover your changes, if applicable.
Checklist
Additional Notes