Implement advanced filter configs #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new pytest fixture that creates a test client with predefined filter configurations (tier_id, name, name__startswith) to test filtered endpoints
|
@Simon128 can you please review? |
Will do, I've been quite busy with work the past weeks. I will take a look at this repo on the weekend |
|
@doubledare704 I'd suggest adding the advanced_filters test also to the sqlalchemy tests. I believe it works identically and you just have to copy & paste the parts from conftest.py and test_get_items.py into the corresponding files in the sqlalchemy test folder. |
- Add filtered_client fixtures to SQLAlchemy conftest.py - Add comprehensive test_read_items_with_advanced_filters to test_get_multi.py covering startswith filters - Maintain parity with SQLModel test suite for consistent test coverage Files changed: - tests/sqlalchemy/conftest.py - tests/sqlalchemy/crud/test_get_multi.py
|
@Simon128, I've added conftest for sqlalchemy and test case to alchemy folder |
doubledare704
changed the title
doubledare704
changed the title
…anced-FilterConfigs
doubledare704
deleted the
feature/implement-issue-196-Allowing-for-advanced-FilterConfigs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new pytest fixture that creates a test client with predefined filter configurations (tier_id, name, name__startswith) to test filtered endpoints
Pull Request Template for FastCRUD
Description
I've added changes like author mentioned in #196
Changes
Endpoint Creator now has extended logic in _validate_filter_config, but it waits for developer to add filters in FilterConfig, or like Simon did in generate_filter_configs.
Tests
I've added test case to filter by startwith name, 1 positive case, 1 negative case.
Checklist
Additional Notes
Include any additional information that you think is important for reviewers to know.