Add configurable response key for get_multi method #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doubledare704
force-pushed
the
feature/allow-define-key-for-multi-response
branch
from
6a8cf35 to
2aa727b
Compare
Add multi_response_key parameter to FastCRUD constructor to allow customization of the response key in get_multi results. Default value is "data" for better semantic clarity. - Add multi_response_key parameter with default value "data" - Replace hardcoded response key with configurable one - Maintain backward compatibility with existing implementations
- Update paginated response handling in response.py to support flexible key names - Modify EndpointCreator to use dynamic response models - Add create_list_response and create_paginated_response utility functions - Maintain backward compatibility with existing "data" key Related files: - fastcrud/paginated/response.py - fastcrud/endpoint/endpoint_creator.py - fastcrud/paginated/schemas.py
doubledare704
force-pushed
the
feature/allow-define-key-for-multi-response
branch
from
13e45d9 to
c2ceaf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for FastCRUD
Description
Add multi_response_key parameter to FastCRUD constructor to allow customization of the response key in get_multi results. Default value is "data" for better semantic clarity.
I think it will resolve a #155
Changes
Tests
Added 2 tests to check if response as dict is valid, and if response is model is valid.
Checklist
Additional Notes
Include any additional information that you think is important for reviewers to know.