Models and Schemas, Batch 5: Projects and Participants #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes cleaning up a massive chunk of redundancy/duplication from the section on many-to-many relationships.
igorbenav
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Models and schemas for #72, using the models from the unit tests for projects, project participants, and the associations between the two.
Changes
Doc snippet inclusion markers in unit test config for models:
ProjectParticipantProjectsParticipantsAssociationAlso, addition of a
ReadProjectSchemaand doc/docstring updates overall for all of these.Tests
As noted above,
tests/sqlalchemy/conftest.pyhas snippet markers added for the above models, but are otherwise functionally unchanged.Checklist
Additional Notes
Coming back to this after a while away. I made sure to rebase and otherwise tried to ensure that changes that have happened in the meantime aren't affected, but please let me know if I've missed something.