-
Notifications
You must be signed in to change notification settings - Fork 34
CRM Schemas/Properties CRUD support #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As with the previous PR, all the tests have You should be able to run them in order, e.g. Create, List, Get, Update, Delete and they should reference the correct test schema. Hubspot does require some time between some of these things (e.g. create with an immediate get fails, or immediate update) so I haven't left them as active. This feature also requires an enterprise account. |
8b5dce6
to
b008e61
Compare
Thank you @sblackstone ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a PR comment! Please check.
+ I'm updating the belong-inc:main
branch, so I'd appreciate it if you could take it in.
7dceb24
to
8ca9a8e
Compare
I've attempted to address these issues, all of them should either be resolved or have additional comments.. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your response! Sorry for the delay in responding.
I left an additional comment.
I just pushed an update which moves everything to using pointers and wrapped types. |
I believe everything requested here is done... I squashed all the commits... |
9cbd710
to
6945458
Compare
Thanks for the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your fix.
I have reviewed the whole thing and there are a few things I was wondering about around structure definitions. Please check them.
Thanks for the replies, it may be a few days before I can update this... Stephen |
Hello, Everything here has been updated.. Incidentally, there are some inconsistencies in the Hubspot documentation about what constitutes certain objects. For example,
in a Another example, I've tried to match everything up best I can.. |
I've rebased/squashed this PR.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your response!
If you execute make fmt
and go mod tidy
, I think there will be no problem.
Thank you for taking the time to fix this.
Removed |
@sblackstone |
Hello again!
This patch adds CRUD support for the Hubspot "schemas" API.. (crm/v3/schemas).
Edit: Properties resource is now included.
https://developers.hubspot.com/docs/api/crm/crm-custom-objects
https://developers.hubspot.com/docs/api/crm/properties
Thanks,
Stephen