Only run 'download' actions once core completes + re-add ubuntu-latest to matrix
#276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjrobertson
force-pushed
the
actions_updates
branch
from
a841d3f to
0450d3f
Compare
|
P.S. I pushed one small code change here just to trigger the tests. |
erinhmclark
approved these changes
Mar 26, 2025
| paths: | ||
| - src/** | ||
|
|
||
| jobs: | ||
| tests: | ||
| # Only run if the triggering workflow (tests-core) succeeded | ||
| if: ${{ github.event_name == 'schedule' || github.event.workflow_run.conclusion == 'success' }} |
| # clear out any empty strings that a user may have erroneously added | ||
| continue | ||
| if not check(dep): | ||
| for dep in filter(lambda d: len(d.strip()), deps): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the timestamping enricher is merged, we can now re-enable ubuntu-latest in the testing matrix.
Also, to cut back on the
downloadtests, I've set it to only run once the core tests succeed.