chore: enable pgmonitor #2314
Merged
chore: enable pgmonitor #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Om Mishra <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR enables pgmonitor and adjusts the associated resource requests to better support monitoring in test and production pipelines.
- Enabled pgmonitor by setting its flag to true.
- Increased the CPU request from 1m to 10m and memory request from 16Mi to 32Mi for the pgmonitor exporter.
Comments suppressed due to low confidence (2)
charts/crunchy/values.yaml:120
- [nitpick] Verify that the increased CPU request of 10m meets the performance requirements for pgmonitor under load; if necessary, adjust based on empirical data.
cpu: 10m
charts/crunchy/values.yaml:121
- [nitpick] Ensure that the increased memory allocation to 32Mi for the pgmonitor exporter is sufficient and safe for production environments; consider performance testing if needed.
memory: 32Mi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: