Skip to content

chore: add cors to api tf config #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: add cors to api tf config #941

wants to merge 3 commits into from

Conversation

marcellmueller
Copy link
Contributor

@marcellmueller marcellmueller commented Jun 18, 2025

#851

  • Enabling CORS disables API Cloudfront caching as we shouldn't cache Authorization headers
  • CORS only enabled on admin app

TODO: investigate image issue - we aren't being served up all image variants. This was noticeable on the rec resource page as the images were broken, though working on the search page.

@@ -58,23 +58,27 @@ const RecResourcePage = () => {
useEffect(() => {
if (recResource?.recreation_resource_images) {
setPhotos(
recResource.recreation_resource_images.map((imageObj) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not committing changes to this file, only to debug why we aren't getting all image variants after we deploy with CORS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant