Skip to content

[MDS-6459] TSF bug fixes #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2025
Merged

[MDS-6459] TSF bug fixes #3484

merged 6 commits into from
Apr 3, 2025

Conversation

sggerard
Copy link
Collaborator

@sggerard sggerard commented Apr 1, 2025

Objective

MDS-6459

Fixes a number of minor bugs with TSF & Dams

  • Add missing timezone to HistoryMixin and make tailings use it too.
  • Don't submit the dam form on exit if the user was in view mode or form is untouched.
  • Replace route param id with mineGuid as is used on other Mine tailings routes.

@sggerard sggerard requested a review from taraepp April 1, 2025 22:08
@sggerard sggerard added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Apr 1, 2025
@taraepp
Copy link
Collaborator

taraepp commented Apr 2, 2025

I don't think this addresses the URL parameter on MineSpace issue (Observation #4 on the ticket).
If you go to TailingsTable.tsx in MineSpace, console log the mineGuid ~ln 39, it'll always be undefined. I did do a commit (to the wrong repo...) for that one if you wanted to take a look: develop...EYDS-CA:mds:fix-tailings-mine-undefined

Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
52.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Apr 2, 2025

Copy link

sonarqubecloud bot commented Apr 2, 2025

@@ -40,7 +40,7 @@ class TailingsStorageFacilityType(Enum):
def __str__(self):
return self.value

class MineTailingsStorageFacility(AuditMixin, Base):
class MineTailingsStorageFacility(AuditMixin, HistoryMixin, Base):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about doing this, but didn't actually do it (because scope I guess?), and I'm glad you did.

@sggerard sggerard merged commit 320bed4 into develop Apr 3, 2025
19 of 20 checks passed
@sggerard sggerard deleted the mds-6459-tsf-bug-fixes branch April 3, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants