[MDS-6385] NoD decision document upload conditions #3459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taraepp
reviewed
Mar 12, 2025
| @@ -209,8 +220,16 @@ const NoticeOfDepartureModal: React.FC<NoticeOfDepartureModalProps> = (props) => | |||
| }; | |||
| }) | |||
| ); | |||
|
|
|||
| setCurrentStatus(props?.initialValues?.nod_status); | |||
There was a problem hiding this comment.
I'm wondering if you can simplify things here with something like currentStatus = formValues?.nod_status since it always seems to be equal to that. Setting the initialValues on the form should also set the formValues.
There was a problem hiding this comment.
You're right it does work with that change, its much cleaner.
|
taraepp
approved these changes
Mar 12, 2025
sggerard
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-6385
In NoD adjusted the requirement to upload a decision document to be only for statuses of "determined not substantial" and "determined substantial"
Uploading decision document not required when there is an existing one.