Skip to content

[MDS-6057] Report select condition UI tweaks #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

sggerard
Copy link
Collaborator

@sggerard sggerard commented Mar 6, 2025

Objective

MDS-6057
Additional UI tweaks to when submitting a report using verified permit conditions.

image

Used uniqBy() to dedupe the options based on the report name/type so that the same report doesn't appear multiple times to the user.

Changed the default behavior to not show the empty info box when a report isn't selected.
Modified scss rules so if there's a large number of report options it will instead overflow and scroll.
Also made the info box sticky so it stays on the page as a user scrolls down.

I've been having haystack issues all day so haven't been able to test against a wide range of permits.

Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
14.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Mar 6, 2025

@taraepp taraepp merged commit 28a27ed into develop Mar 6, 2025
16 of 17 checks passed
@taraepp taraepp deleted the mds-6057-report-select-condition-changes branch March 6, 2025 19:37
@sggerard sggerard restored the mds-6057-report-select-condition-changes branch March 6, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants