Skip to content

[MDS-6397] Disable "Edit permit conditions" except for NoW permits #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Feb 27, 2025

Objective

MDS-6397

Why are you making this change? Provide a short explanation and/or screenshots

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
19.2% Coverage on New Code (required ≥ 80%)
29.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
65.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@taraepp
Copy link
Collaborator Author

taraepp commented Feb 28, 2025

So, this testing is kinda lousy (counting the number of dispatches instead of the resulting state, for example)
And the way I set up the state is also kind of lousy (I'm not sure how exactly I'd like to see it set up)

But the intention here is basically:

  • get ready to convert permitSelectors/reducer/actionCreator into a slice
    • then revamp testing
    • maybe re-jigger the state setup too (consumers of selectors should not have to be aware of the state structure!)
  • and also get things a little closer to making more granular network requests, like just for the conditions, or just for the amendment, in other situations

@taraepp taraepp merged commit cb72827 into develop Mar 4, 2025
15 of 17 checks passed
@taraepp taraepp deleted the mds-6397-now-edit-conditions branch March 4, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants