[MDS-6395] Remove Skeleton from Permit Conditions #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

taraepp merged 2 commits into develop from mds-6395-remove-skeleton

Feb 26, 2025

Collaborator

taraepp commented Feb 25, 2025 •

edited

Loading

Objective

for a smoother user experience
there's a lot of subforms and stuff, so added loading/setLoading to the context provider instead of props passing
snuck in some useDispatch --> useAppDispatch
Just a note that on the icon buttons with no text- using "loading" doesn't fit in the button, so it renders a spinner below the button (ew) so I used disabled for those buttons, although I generally prefer loading > disabled

taraepp added 2 commits

February 25, 2025 22:20


          remove skeleton, track loading instead

50bfba9


          some little fixes- the submit button, add in something I shouldn't ha…

2e549ac

…ve taken out, more loading indicators

sonarqubecloud bot commented Feb 25, 2025

Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud bot commented Feb 25, 2025

Quality Gate passed for 'bcgov-sonarcloud_mds_common'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud bot commented Feb 25, 2025

Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

taraepp requested review from simensma-fresh, matbusby-fw, asinn134 and sggerard

February 25, 2025 22:54

Collaborator

sggerard commented Feb 26, 2025

Changes work great!

sggerard approved these changes

View reviewed changes

simensma-fresh approved these changes

View reviewed changes

taraepp merged commit c9c3c52 into develop

17 checks passed

taraepp deleted the mds-6395-remove-skeleton branch

February 26, 2025 23:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet