[MDS-6362] NoW documents not being properly added to NoW reviews #3403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored NOWReviewForm from a class-based component to a functional component and migrated from JavaScript to TypeScript. Updated related validation logic, state handling with hooks, and Redux integration using TypeScript-friendly patterns. Adjusted the API to handle document data as objects instead of tuples to improve clarity and maintainability.
|
|
matbusby-fw
added
the
👍 Ready for review
asinn134
approved these changes
Feb 5, 2025
taraepp
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onFileLoad function wasn't firing in the current iteration. I couldn't find a solid reason why not, but I elected to simply update the component to Typescript and adjust some imports, and it seems to be working correctly now.
Objective
MDS-6362