Skip to content

[MDS-6328] - Select permit document to extract conditions from 🍰 #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 28, 2025
Merged

[MDS-6328] - Select permit document to extract conditions from 🍰 #3389

merged 7 commits into from
Jan 28, 2025

Conversation

matbusby-fw
Copy link
Collaborator

@matbusby-fw matbusby-fw commented Jan 27, 2025 •
edited
Loading

Objective

  • Added logic to ViewPermit to check if there are multiple documents associated with the permit, and if so, open a modal to select which one to extract from.
  • If there is only a single document, it will imediately start the extraction on that document as before.

MDS-6328

image

@matbusby-fw
Add permit document selection modal for condition extraction
4050396 
Enhanced the extraction process by introducing a modal to select specific permit amendment documents when multiple are available.
@matbusby-fw
Add tests and snapshot for PermitConditionsSelectDocumentModal
c397e8f
@matbusby-fw
update snaps
4797a83
@matbusby-fw
update snaps
bdd9006
@matbusby-fw matbusby-fw marked this pull request as ready for review January 27, 2025 21:18
@matbusby-fw matbusby-fw added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Jan 27, 2025
simensma-fresh
simensma-fresh previously approved these changes Jan 28, 2025
View reviewed changes
@sggerard
Copy link
Collaborator

Looks great!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_common'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
70.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matbusby-fw matbusby-fw merged commit dd5c931 into develop Jan 28, 2025
19 of 20 checks passed
@matbusby-fw matbusby-fw deleted the mds-6328-select-permit-extraction-doc branch January 28, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asinn134 asinn134 asinn134 approved these changes

@sggerard sggerard sggerard approved these changes

@simensma-fresh simensma-fresh simensma-fresh left review comments

@taraepp taraepp Awaiting requested review from taraepp

Assignees
No one assigned
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matbusby-fw @sggerard @simensma-fresh @taraepp @asinn134