[MDS-6194] Major project duplication #3269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
simensma-fresh
approved these changes
Oct 17, 2024
matbusby-fw
added
the
👍 Ready for review
taraepp
reviewed
Oct 17, 2024
| const projectFormTabs = null; | ||
| const projectFormTabs = getProjectFormTabs( | ||
| amsFeatureEnabled, | ||
| isCore, |
There was a problem hiding this comment.
Y'know, I even noticed that this function was throwing errors!
Technically this should always be false as this is a MineSpace file, but I'm not bothered by a bit of extra robustness.
There was a problem hiding this comment.
Yeah, I thought might as well add the actual flag for that imaginary case where this component gets used in Core at some point for some weird unknown reason.
taraepp
approved these changes
Oct 17, 2024
asinn134
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
On the
ProjectSummaryPagein Minespace theprojectFormTabsvariable was null. As a result, when the system attempted to replace the current url with one containing the new project and project summary guids it would pass in that null value as part of the route and fail.Loaded the projectFormTabs properly and it seems to work fine.
MDS-6194