[MDS-6114] update AMS fields #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

henryoforeh-dev merged 8 commits into develop from MDS-6114-ams-fields

Oct 9, 2024

Contributor

henryoforeh-dev commented Oct 7, 2024

Objective

Why are you making this change? Provide a short explanation and/or screenshots

Generated migration script to alter columns according to AMS specs.
Added new attributes to the AMS API service.
Updated fields in FE application to match AMS specs.

henryoforeh-dev added 3 commits

October 7, 2024 08:15

wip

c7ec9d7


          add payment contact info

5437a16


          update snapshot test.

f19582e

henryoforeh-dev requested review from simensma-fresh, matbusby-fw, taraepp and asinn134

October 8, 2024 12:45

asinn134 previously approved these changes

View reviewed changes

taraepp reviewed

View reviewed changes

services/common/src/components/projectSummary/LegalLandOwnerInformation.tsx Outdated

@@ @@ -104,7 +104,7 @@ export const LegalLandOwnerInformation: FC = () => { @@
                               label="Legal Land Owner Name"
                               component={RenderField}
                               required={!is_legal_land_owner}
-                              validate={!is_legal_land_owner ? [required] : []}
+                              validate={!is_legal_land_owner ? [required, maxLength(100)] : []}

Collaborator

taraepp Oct 8, 2024

For this one and the one below- we only want the required validation when they're not the legal land owner, but shouldn't the other methods be in the second array? Like if it's not required, it should still have a max length, and below even if it's not required should still follow email validation. Existing issue I guess but may as well fix it?


          update validation

bc940e4

henryoforeh-dev dismissed asinn134’s stale review via

bc940e4

October 8, 2024 23:35

henryoforeh-dev added 4 commits

October 8, 2024 17:47


          revert changes to snapshot file

ac5f2d5


          revert changes.

21249e8


          fix bug.

cbe318a


          fix snapshot test

255d0f4

sonarqubecloud bot commented Oct 9, 2024

Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud bot commented Oct 9, 2024

Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud bot commented Oct 9, 2024

Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud bot commented Oct 9, 2024

Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
28.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

asinn134 approved these changes

View reviewed changes

taraepp approved these changes

View reviewed changes

henryoforeh-dev merged commit 93c36f8 into develop

15 of 17 checks passed

henryoforeh-dev deleted the MDS-6114-ams-fields branch

October 9, 2024 17:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet