[MDS-5844] Declaration page #3046

taraepp · 2024-04-09T22:00:01Z

Objective

add the declaration page

MDS-5844

Why are you making this change? Provide a short explanation and/or screenshots

gif of page fold wrapper component in action is too big for GH, but it's posted on the ticket

…ontent above page fold

…Table also uses Collapse, updated to use attributes instead of setting global style.

…ox display, do FE & BE testing

taraepp · 2024-04-09T22:10:59Z

services/common/src/redux/selectors/projectSelectors.ts

@@ -39,26 +39,31 @@ const formatProjectContact = (contacts): IProjectContact[] => {

  return formattedContacts;
 };
-const formatAuthorizations = (authorizations = [], authTypes) => {
+const formatAuthorizations = (authorizations = [], amsAuthTypes, statusCode) => {


this param was always amsAuthTypes, just made it more obvious

taraepp · 2024-04-09T22:13:18Z

...ents/Forms/projects/informationRequirementsTable/ReviewSubmitInformationRequirementsTable.js

-const renderSubrequirement = (item) => item.map((it) => <Subrequirement sub_requirement={it} />);
+const renderSubrequirement = (item) =>
+  item.map((it) => {
+    //eslint-disable-next-line @typescript-eslint/no-use-before-define


all I wanted to do in this file was add a bordered=false param below, but eslint was not happy about that rule, and I found that the logic was kind of circular. I did give it its missing key though.

taraepp · 2024-04-09T22:15:14Z

services/minespace-web/src/styles/overrides/antd-overrides.scss

@@ -280,7 +280,6 @@ h5.ant-typography,
 }

 .ant-table-thead>tr>th {
-  background: #F7F8FA;


This hasn't actually changed, but now it's in the webpack variables! Who knew that the index.pure.less rules I'm always fighting were defined by us all along...

taraepp · 2024-04-09T22:16:33Z

services/minespace-web/src/styles/settings/theme.scss

-  $primary-color,
-  80%
-); //color(~`colorPalette('${primary-color}', 2) `); // replace tint($primary-color, 80%)
+$primary-1: tint($primary-color,


I think that all of the changes I made in theme.scss I ended up reverting in a later commit, so this is all eslint.

taraepp · 2024-04-09T22:18:00Z

services/minespace-web/webpack.parts.js

@@ -163,13 +163,13 @@ exports.loadCSS = ({ include, exclude } = {}) => ({
                  "border-color-base": "#003366",
                  "border-color-split": "#efefef",
                  "border-width-base": "2px",
-                  "background-color-light": "#f7f8fa",
+                  "background-color-light": "#f2f2f2",


Turns out that this is where we go for changing global style variables, I feel kind of silly for not knowing/remembering before. I see you, border-radius: 5px. 👀

taraepp · 2024-04-12T16:35:17Z

services/minespace-web/webpack.config.ts

@@ -215,7 +214,7 @@ const prodConfig = merge([
  }),
  parts.bundleOptimization({
    options: {
-      maxSize: 3000000,
+      // maxSize: 3000000,


Note for the future: the bundle splitting was causing errors in loading, follow up ticket made.

henryoforeh-dev · 2024-04-12T16:43:44Z

services/minespace-web/src/styles/components/Forms.scss

+//         color: $gov-red;
+//     }
+
+// }


Will this commented code still be used in future ?

ah this got missed in my reverting/unreverting. Going to re-instate it- it's necessary to show required mark on checkbox. Good catch!

henryoforeh-dev

Nice, just a minor comment.

sonarqubecloud · 2024-04-12T17:00:18Z

Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud · 2024-04-12T17:00:30Z

Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud · 2024-04-12T17:00:35Z

Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-04-12T17:00:48Z

Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

* bulk of FE work for Declaration page, wrapper component for keeping content above page fold * all the styling and layout fixes. ReviewSubmitInformatioNRequirementsTable also uses Collapse, updated to use attributes instead of setting global style. * revert some FE changes, validate data on BE, fix an issue with checkbox display, do FE & BE testing * be really explicit with cypress instructions * test * add selectors to core-web * seeing if anything sticks * seeing if commented out code passes in pipeline * commenting out all scss changes on core * comment out all scss additions on MS * 🤷‍♀️ * commenting out changes in webpack * stay unbroken? * restore 'safe' css rules in core and remove commented out * just one webpack variable... * testing if it's a mismatch causing the issue * seeing if same thing happens in CORE * fix undefined variable in CORE * revert test change on CORE, remove undefined from function params * test make extractCSS call the same and bundleOptimization * re-instate variable changes * try putting maxSize back on * disable max size for now * taking out commented out code * put back required mark on checkboxes

taraepp added 3 commits April 9, 2024 22:00

bulk of FE work for Declaration page, wrapper component for keeping c…

2332c02

…ontent above page fold

all the styling and layout fixes. ReviewSubmitInformatioNRequirements…

2beaa9c

…Table also uses Collapse, updated to use attributes instead of setting global style.

revert some FE changes, validate data on BE, fix an issue with checkb…

772cfa9

…ox display, do FE & BE testing

taraepp force-pushed the mds-5844-terms branch from 06d71b6 to 772cfa9 Compare April 9, 2024 22:02

taraepp commented Apr 9, 2024

View reviewed changes

taraepp added 20 commits April 10, 2024 15:15

be really explicit with cypress instructions

af2875b

test

0f959dd

add selectors to core-web

3a0ed20

seeing if anything sticks

b9b45b1

seeing if commented out code passes in pipeline

a61bbf8

commenting out all scss changes on core

9621664

comment out all scss additions on MS

fe08396

🤷‍♀️

86fb417

commenting out changes in webpack

4d64ddd

stay unbroken?

3cd14a9

restore 'safe' css rules in core and remove commented out

0be3450

just one webpack variable...

7e4d061

testing if it's a mismatch causing the issue

39ea36d

seeing if same thing happens in CORE

c434096

fix undefined variable in CORE

acc29dc

revert test change on CORE, remove undefined from function params

c700622

test make extractCSS call the same and bundleOptimization

241dfd4

re-instate variable changes

b0f2f41

try putting maxSize back on

d04c3e9

disable max size for now

83927db

taraepp marked this pull request as ready for review April 12, 2024 16:33

taraepp commented Apr 12, 2024

View reviewed changes

taking out commented out code

eb9971b

taraepp requested review from simensma-fresh, henryoforeh-dev, matbusby-fw, isuru-aot and asinn134 April 12, 2024 16:39

henryoforeh-dev reviewed Apr 12, 2024

View reviewed changes

henryoforeh-dev previously approved these changes Apr 12, 2024

View reviewed changes

put back required mark on checkboxes

1d296ba

taraepp dismissed henryoforeh-dev’s stale review via 1d296ba April 12, 2024 16:59

henryoforeh-dev approved these changes Apr 12, 2024

View reviewed changes

asinn134 approved these changes Apr 15, 2024

View reviewed changes

taraepp merged commit ae55620 into develop Apr 15, 2024

taraepp deleted the mds-5844-terms branch April 15, 2024 19:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MDS-5844] Declaration page #3046

[MDS-5844] Declaration page #3046

Uh oh!

taraepp commented Apr 9, 2024 •

edited

Loading

Uh oh!

taraepp Apr 9, 2024

Uh oh!

taraepp Apr 9, 2024

Uh oh!

taraepp Apr 9, 2024

Uh oh!

taraepp Apr 9, 2024

Uh oh!

taraepp Apr 9, 2024

Uh oh!

taraepp Apr 12, 2024

Uh oh!

henryoforeh-dev Apr 12, 2024

Uh oh!

taraepp Apr 12, 2024

Uh oh!

henryoforeh-dev left a comment

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Uh oh!

Uh oh!

[MDS-5844] Declaration page #3046

[MDS-5844] Declaration page #3046

Uh oh!

Conversation

taraepp commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henryoforeh-dev left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Uh oh!

Uh oh!

taraepp commented Apr 9, 2024 •

edited

Loading