[MDS-5860] Fix inconsistent toast error message from api calls #3032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbusby-fw
requested review from
taraepp,
asinn134,
henryoforeh-dev and
isuru-aot
taraepp
reviewed
Apr 3, 2024
services/core-api/app/api/notice_of_departure/resources/notice_of_departure_list.py
Outdated
Show resolved
Hide resolved
matbusby-fw
dismissed stale reviews from asinn134 and henryoforeh-dev
via
7eae17f
|
|
|
|
henryoforeh-dev
approved these changes
Apr 3, 2024
asinn134
approved these changes
Apr 3, 2024
simensma-fresh
pushed a commit
that referenced
this pull request
Jun 12, 2024
* remove throwing errors where no catch blocks exist * remove unnecessary conditional * updated test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Errors that were being thrown by the frontend were being overridden when an action creator contained
throw new Error(), but it's invocation didn't contain acatchblock.Did a search throughout the frontends and only found a very limited number of catch blocks, so removed the throw new Error from all actionCreators where this didn't exist.
MDS-5860