Skip to content

[MDS-5737] Fixed opening of document viewer from action menu and other Document Viewer issues #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2024
Merged

[MDS-5737] Fixed opening of document viewer from action menu and other Document Viewer issues #2895

merged 1 commit into from
Jan 17, 2024

Conversation

simensma-fresh
Copy link
Collaborator

Objective

MDS-5737

Fixed a couple of issues around the document viewer

  • The "Open in Document Viewer" action button downloads the document instead of opening in the document viewer in both minespace and core: Second param to openDocument is the document name, not guid
  • The Document Viewer fails with an error in Minespace: PDF Viewer service url param name was wrong
  • Document Viewer doesn't work locally: Newly uploaded files didn't have the S3_PREFIX appended for multipart uploads

@simensma-fresh simensma-fresh changed the title [MDS-5737] Fixed opening of document viewer from action menu [MDS-5737] Fixed opening of document viewer from action menu and other Document Viewer issues Jan 17, 2024
@simensma-fresh simensma-fresh added 🐞 Bug Something isn't working :( 💻 Frontend This pull request includes frontend changes. 🚌 Common Package This pull request updates the common package 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. labels Jan 17, 2024
matbusby-fw
matbusby-fw approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📎

henryoforeh-dev
henryoforeh-dev approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@simensma-fresh simensma-fresh merged commit 9490acc into develop Jan 17, 2024
@simensma-fresh simensma-fresh deleted the MDS-5737_PDF-document-viewer branch January 17, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryoforeh-dev henryoforeh-dev henryoforeh-dev approved these changes

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@taraepp taraepp Awaiting requested review from taraepp

@isuru-aot isuru-aot Awaiting requested review from isuru-aot

@asinn134 asinn134 Awaiting requested review from asinn134

Assignees
No one assigned
Labels
🐞 Bug Something isn't working :( 🚌 Common Package This pull request updates the common package 💻 Frontend This pull request includes frontend changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simensma-fresh @henryoforeh-dev @matbusby-fw