[MDS-5552]replacing now manage doc and admin with zip download #2774
Conversation
asinn134
requested review from
henryoforeh-dev,
matbusby-fw,
taraepp and
isuru-aot
| @@ -366,6 +366,7 @@ export const DocumentTable: FC<DocumentTableProps> = ({ | |||
| setCompressionModalVisible={setCompressionModal} | |||
| isCompressionModalVisible={isCompressionModal} | |||
| compressionInProgress={setCompressionInProgress} | |||
| showArchiveDownloadWarning={true} | |||
There was a problem hiding this comment.
would true be a reasonable default for this prop?
There was a problem hiding this comment.
@taraepp that is a good point. I initially thought to set this prop as a way to temporarily disable the archive warning modal that pops up because NoW section hasn't had archive and versioning setup yet. At the same time, it is possible for other sections not just Major Projects or NoW to use document compression within the DocumentTable since DocumentTable is used in alot of different areas that also don't have archive or versioning files.
Would it make more sense to use DocumentTable's props showVersionHistory and canArchiveDocuments. So something like showDownloadWarning={showVersionHistory || canArchiveDocuments}
There was a problem hiding this comment.
I adjusted the DocumentTable's showDownloadWarning default value to be based on showVersionHistory || canArchiveDocuments in the latest commit.
asinn134
dismissed stale reviews from henryoforeh-dev and matbusby-fw
via
0e966ac
Objective
MDS-5552
Replaces the existing download of NoW documents and Permit Package documents in NoW Manage Documents tab with download zip, similar to Major projects.
Replaces the existing download of Permit Package documents in NoW Administrative tab with download zip, similar to Major projects.