[MDS-3871] - update esup permit template with inspector name #2758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit includes changes to the Explosives Permit and Amendments action menus to improve user experience. The action menu for amendments is now view-only to prevent unauthorized edits. The commit also includes changes for processing images, particularly for handling naming conventions and appending necessary values. An additional library, Pillow, has been added to the package requirements to support image processing. Changes were made following user feedback to simplify navigation and enhance usability.
matbusby-fw
force-pushed
the
mds-3871-esup-permit-inspector-name
branch
from
d6e38cd to
0ecd0d2
Compare
taraepp
reviewed
Oct 26, 2023
| width = height_in_pixels * aspect_ratio | ||
| # Convert width from pixels back to inches | ||
| width = width / 96 | ||
|
|
taraepp
approved these changes
Oct 26, 2023
asinn134
reviewed
Oct 26, 2023
| @@ -48,6 +52,27 @@ def validate_issuing_inspector(explosives_permit): | |||
| raise Exception('No signature for the Issuing Inspector has been provided') | |||
|
|
|||
| def create_image(source, width=None, height=None): | |||
|
|
|||
| # If there is a prefix in the source, remove it | |||
| base64_source = source | |||
There was a problem hiding this comment.
nice work with this part
There was a problem hiding this comment.
Yeah, took a bit of figuring to get it working just right.
asinn134
approved these changes
Oct 26, 2023
henryoforeh-dev
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also noticed a couple of esup things that needed fixing
Objective
MDS-3871