-
Notifications
You must be signed in to change notification settings - Fork 38
[MDS-5432] Update UI for ESUP tables #2740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taraepp
reviewed
Oct 24, 2023
services/core-web/src/components/mine/ExplosivesPermit/MineExplosivesPermitTable.tsx
Outdated
Show resolved
Hide resolved
taraepp
reviewed
Oct 24, 2023
services/core-web/src/components/mine/ExplosivesPermit/MineExplosivesPermitTable.tsx
Outdated
Show resolved
Hide resolved
taraepp
reviewed
Oct 25, 2023
services/core-web/src/components/mine/ExplosivesPermit/MineExplosivesPermitTable.tsx
Outdated
Show resolved
Hide resolved
taraepp
reviewed
Oct 25, 2023
services/core-web/src/components/mine/ExplosivesPermit/MineExplosivesPermitTable.tsx
Outdated
Show resolved
Hide resolved
7ea58c3
to
e735399
Compare
Changed how user interface elements are structured in the explosives permit view. The key changes include renaming 'status' to 'is_closed' for clearer understanding, changing rows into divs, and adding 'className' property to improve the look and feel. Besides, various components from the antd library were introduced to render the content in a more structured and aesthetically pleasing way. Changes were made to support upcoming features and improve usability.
e735399
to
9240a1f
Compare
asinn134
approved these changes
Oct 25, 2023
henryoforeh-dev
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and easy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the columns and expand columns for the esups tables
(More than half of the files changed are updated snaps from unrelated components)
Objective
MDS-5432