Skip to content

[MDS-5402] Added fontawesome icon to homepage + added utility to fetch and configure fontawesome pro access key #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

simensma-fresh
Copy link
Collaborator

Objective

MDS-5402

Added fontawesome icons to homepage.

env variable fetching
I had some fun and expanded make env a little bit to look up and configure yarn to use the FontAwesome pro token that I added to the local-dev-secrets secret in the 4c2ba9-dev openshift namespace.

Why? This is the first secret that is required to actually build and run the app locally, and it would be good to avoid sharing it manually as much as possible. I imagine we would be able to build on top of this for other secrets (hey S3 Access Key).

make env will now

  1. Prompt to re-generate .env
  2. Prompt to load secrets from OpenShift
  3. Prompt to install oc binary (only in codespaces)
  4. Prompt to log into Openshift
  5. Configure yarn with FontAwesome secret

image
image
image
image
image

@simensma-fresh simensma-fresh marked this pull request as ready for review September 19, 2023 21:29
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@simensma-fresh simensma-fresh merged commit e04d56e into develop Sep 20, 2023
@simensma-fresh simensma-fresh deleted the MDS-5402_Homepage-tweaks branch September 20, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants