Skip to content

[MDS-5402] Fixed metabase embeds not showing up on homepage #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

simensma-fresh
Copy link
Collaborator

Objective

MDS-5402

The new metabase reports for the homepage are questions, not dashboards, which require slightly different urls.

@simensma-fresh simensma-fresh added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💾 Backend This pull request includes backend changes. 💻 Frontend This pull request includes frontend changes. ⌨️ Typescript This pull request includes Typescript changes labels Sep 14, 2023
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@simensma-fresh simensma-fresh merged commit 674c9ee into develop Sep 14, 2023
@simensma-fresh simensma-fresh deleted the MDS-5402_Fix-dashboard-embeds branch September 14, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 Backend This pull request includes backend changes. 💻 Frontend This pull request includes frontend changes. ⌨️ Typescript This pull request includes Typescript changes 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants