[MDS-5450] Use selectin loader for Incident documents, and TSFs #2640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so just remade in functional/TS format
…ange route to point to new home page (will rename later)
…changes so just remade in functional/TS format" This reverts commit 3ab20a7c0f15a9086512ab73a73a2d2d68c09263.
…erts. Change route to point to new home page (will rename later)" This reverts commit 733982367a3a291da852ba3d8567ae77e44e7816.
simensma-fresh
requested review from
henryoforeh-dev,
matbusby-fw,
taraepp,
isuru-aot and
asinn134
asinn134
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5450
Attempt to improve the performance of the Incident endpoints which in some circumstances causes the core api to error with an OOM error.
EXPLAIN ANALYZEing the filter query, I found that the document and TSF joins was a big reason for the amount of rows being returned by the query.
Note:
This does not solve the overall issue around only returning the data we need - why do we need TSFs loaded when looking up an Incident? Turns out that's a bit of a bigger thing, but hopefully this PR should resolve the immediate issue.