Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I saw your comment on reddit, and thought I'd take a go at adding Magnus to the set of libraries covered by these benchmarks.
I didn't quite get everything running in my environment, and I didn't want to bombard you with a bunch of irrelevant changes, so this is just the stuff to add Magnus.
Despite not being able to compare against the full set of the other libraries, I don't think Magnus does great at this particular benchmark. I think I spotted a potential for improvement in Magnus, so there might be another PR in the future to bump the version when I get the opportunity to make that improvement and release a new version.
I'd be interested if this makes a difference to your conclusions.
Thanks!