Skip to content

Add benchmark for Magnus #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

matsadler
Copy link

Hi!

I saw your comment on reddit, and thought I'd take a go at adding Magnus to the set of libraries covered by these benchmarks.

I didn't quite get everything running in my environment, and I didn't want to bombard you with a bunch of irrelevant changes, so this is just the stuff to add Magnus.

Despite not being able to compare against the full set of the other libraries, I don't think Magnus does great at this particular benchmark. I think I spotted a potential for improvement in Magnus, so there might be another PR in the future to bump the version when I get the opportunity to make that improvement and release a new version.

I'd be interested if this makes a difference to your conclusions.

Thanks!

it'll handle the conversion fine, just happened to copy/paste
from an example where it was required
@matsadler
Copy link
Author

I've added a commit to bump Magnus to the latest version. With this I'm actually seeing Rust + Magnus coming in at slightly faster than C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant