Skip to content

appnote: Add appnote on long-running Flows/Sources #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

samdbmg
Copy link
Member

@samdbmg samdbmg commented Aug 22, 2024

Details

Adds an application note describing how identity could be handled for long-running Flows and Sources.

Also fixes a missing appnote in the README ToC

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/187940341

Related PRs

N/A

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@samdbmg samdbmg requested a review from a team as a code owner August 22, 2024 10:15
@samdbmg samdbmg force-pushed the sammg-add-long-running-sources-appnote branch from f8b7e74 to fa6f601 Compare August 22, 2024 10:16
@j616 j616 self-assigned this Aug 23, 2024
Copy link
Contributor

@j616 j616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM. Couple of nits.

Also, is it worth mentioning that if you have consistent timing and identity throughout your system, and accurately timed metadata, you can achieve time accurate splitting of flows on shared lines according to bookings. If you don't have such accurate timing and metadata available, you may get some overlap of content at the start/end.

Adds a appnote describing how identity should be handled for
long-running Flows and Sources.

Co-authored-by: James Sandford <[email protected]>
@samdbmg samdbmg force-pushed the sammg-add-long-running-sources-appnote branch from 5619d8a to c4b30bc Compare August 23, 2024 11:21
@samdbmg
Copy link
Member Author

samdbmg commented Aug 23, 2024

Also, is it worth mentioning that if you have consistent timing and identity throughout your system, and accurately timed metadata, you can achieve time accurate splitting of flows on shared lines according to bookings. If you don't have such accurate timing and metadata available, you may get some overlap of content at the start/end.

Good point, I've added a sentence about this

@j616 j616 merged commit 3917b1b into main Aug 29, 2024
5 checks passed
@j616 j616 deleted the sammg-add-long-running-sources-appnote branch August 29, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants